Skip to content

/ go

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls: signature help and completion should respect the user's hoverKind setting #38577

Closed
stamblerre opened this issue Apr 22, 2020 · 1 comment
Closed

x/tools/gopls: signature help and completion should respect the user's hoverKind setting #38577

stamblerre opened this issue Apr 22, 2020 · 1 comment
Assignees
@stamblerre
Labels
Tools gopls
Milestone
gopls/v0.5.3

Comments

@stamblerre
Copy link
Contributor

@stamblerre stamblerre commented Apr 22, 2020

Currently, we always send synopsis documentation, but it would be preferable to respect the user's hover setting. Even better, we should follow the same code path to generate the documentation.
@stamblerre stamblerre added this to the gopls/v0.5.0 milestone Apr 22, 2020
@stamblerre stamblerre modified the milestones: gopls/v0.5.0, gopls/v1.0.0 Jul 22, 2020
@stamblerre stamblerre changed the title x/tools/gopls: signature help should respect the user's hoverKind setting x/tools/gopls: signature help and completion should respect the user's hoverKind setting Oct 7, 2020
@stamblerre stamblerre self-assigned this Oct 29, 2020
@gopherbot
Copy link

@gopherbot gopherbot commented Oct 29, 2020

Change https://golang.org/cl/266139 mentions this issue: internal/lsp/source: respect user's hover kind in signature help
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stamblerre stamblerre

Labels
Tools gopls
Projects
None yet
Milestone
gopls/v0.5.3
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@stamblerre @gopherbot