Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/pkgsite: subdirectories are missing for nested modules #38596

Open
tschaub opened this issue Apr 22, 2020 · 2 comments
Open

x/pkgsite: subdirectories are missing for nested modules #38596

tschaub opened this issue Apr 22, 2020 · 2 comments

Comments

@tschaub
Copy link

@tschaub tschaub commented Apr 22, 2020

What is the URL of the page with the issue?

https://pkg.go.dev/cloud.google.com/go?tab=subdirectories

What is your user agent?

Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_3) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/81.0.4044.113 Safari/537.36

Screenshot

image

What did you expect to see?

I was looking for a link to the storage package. This is listed on the godoc.org as a subdirectory.

image

I don't see a link to the same under the subdirectories tab from pkg.go.dev.

What did you see instead?

The list of subdirectories does not include storage.

@gopherbot gopherbot added this to the Unreleased milestone Apr 22, 2020
@gopherbot gopherbot added the pkgsite label Apr 22, 2020
@julieqiu
Copy link
Contributor

@julieqiu julieqiu commented Apr 22, 2020

Thanks for the feedback! The reason storage is not listed there is because cloud.google.com/go/storage is a nested module:
https://github.com/googleapis/google-cloud-go/blob/v0.56.0/storage/go.mod

This means that it is not a subdirectory of cloud.google.com/go. When you download cloud.google.com/go via proxy.golang.org (https://proxy.golang.org/cloud.google.com/go/@v/v0.56.0.zip), you will notice that it is not there.

We understand that this is confusing from a UI perspective and plan to address it in the upcoming round of design changes.

/cc @fflewddur @Joanne881107

@julieqiu julieqiu changed the title go.dev: Missing subdirectories pkg.go.dev: subdirectories are missing for nested modules Apr 22, 2020
@tschaub
Copy link
Author

@tschaub tschaub commented Apr 23, 2020

Thanks for the explanation, @julieqiu. I see that the old documentation is actually misleading in this case.

I wonder if it would help if the UI were explicit about packages and nested modules instead of using "subdirectories" to describe these things. I don’t know if "nested" is a formal class of modules, but it would help clarify what you get when installing a module (packages) vs. what you need to install separately (modules that may share part of the same path).

@julieqiu julieqiu changed the title pkg.go.dev: subdirectories are missing for nested modules x/pkgsite: subdirectories are missing for nested modules Jun 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.