Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
GitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
database/sql: TestTxCannotCommitAfterRollback failures on windows-amd64-2008 builder #38597
Marking as release-blocker for Go 1.15, since this appears to be a regression.
@bcmills The commit right before is not relevant. I'm not sure a new test for that commit would be beneficial.
The flaking test is a new test merged in https://go-review.googlesource.com/c/go/+/216240 two days ago. The CL fixes a real issue, but harder to test for. I'll look into the Test to try to determine why it is flaking.
…rRollback Do not cancel rows during test. Only cancel the Tx. Correct the referenced issue number on the test. Updates #38597. Fixes #41815. Change-Id: I0e8ba1bf2a8ba638d121c9c6938501fec1d5e961 Reviewed-on: https://go-review.googlesource.com/c/go/+/229478 Run-TryBot: Daniel Theophanes <firstname.lastname@example.org> TryBot-Result: Gobot Gobot <email@example.com> Reviewed-by: Ian Lance Taylor <firstname.lastname@example.org> (cherry picked from commit ed7888a) Reviewed-on: https://go-review.googlesource.com/c/go/+/259858 Trust: Dmitri Shuralyov <email@example.com> Trust: Emmanuel Odeke <firstname.lastname@example.org> Run-TryBot: Dmitri Shuralyov <email@example.com> Reviewed-by: Emmanuel Odeke <firstname.lastname@example.org> TryBot-Result: Go Bot <email@example.com>