Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

database/sql: TestTxCannotCommitAfterRollback failures on windows-amd64-2008 builder #38597

bcmills opened this issue Apr 22, 2020 · 5 comments


Copy link

@bcmills bcmills commented Apr 22, 2020


These failures occurred just after CL 227278 for #38058 (which, coincidentally, appears to have been merged without a corresponding regression test).

Marking as release-blocker for Go 1.15, since this appears to be a regression.

CC @kardianos @odeke-em @colinking

Copy link

@kardianos kardianos commented Apr 22, 2020

@bcmills The commit right before is not relevant. I'm not sure a new test for that commit would be beneficial.

The flaking test is a new test merged in two days ago. The CL fixes a real issue, but harder to test for. I'll look into the Test to try to determine why it is flaking.

Copy link

@gopherbot gopherbot commented Apr 22, 2020

Change mentions this issue: database/sql: de-flake TestTxCannotCommitAfterRollback

@gopherbot gopherbot closed this in ed7888a Apr 22, 2020
Copy link

@dmitshur dmitshur commented Oct 6, 2020

@gopherbot Please backport to Go 1.14. This is a fix for a flaky test. A flaky test makes release testing more difficult and less accurate.

Copy link

@gopherbot gopherbot commented Oct 6, 2020

Backport issue(s) opened: #41815 (for 1.14).

Remember to create the cherry-pick CL(s) as soon as the patch is submitted to master, according to

Copy link

@gopherbot gopherbot commented Oct 6, 2020

Change mentions this issue: [release-branch.go1.14] database/sql: de-flake TestTxCannotCommitAfterRollback

gopherbot pushed a commit that referenced this issue Oct 8, 2020

Do not cancel rows during test. Only cancel the Tx.
Correct the referenced issue number on the test.

Updates #38597.
Fixes #41815.

Change-Id: I0e8ba1bf2a8ba638d121c9c6938501fec1d5e961
Run-TryBot: Daniel Theophanes <>
TryBot-Result: Gobot Gobot <>
Reviewed-by: Ian Lance Taylor <>
(cherry picked from commit ed7888a)
Trust: Dmitri Shuralyov <>
Trust: Emmanuel Odeke <>
Run-TryBot: Dmitri Shuralyov <>
Reviewed-by: Emmanuel Odeke <>
TryBot-Result: Go Bot <>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.