Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build: add a Windows ARM builder #38607

Closed
cagedmantis opened this issue Apr 22, 2020 · 20 comments
Closed

x/build: add a Windows ARM builder #38607

cagedmantis opened this issue Apr 22, 2020 · 20 comments

Comments

@cagedmantis
Copy link
Contributor

@cagedmantis cagedmantis commented Apr 22, 2020

We used to have a Windows ARM builder which was removed because it was no longer supported #38493. We should explore a new service or maintainer in order to restore the builder type.

/cc @andybons @dmitshur @toothrot

@gopherbot
Copy link

@gopherbot gopherbot commented Apr 23, 2020

Change https://golang.org/cl/229559 mentions this issue: dashboard: remove the Windows ARM builder

gopherbot pushed a commit to golang/build that referenced this issue Apr 23, 2020
The host-windows-arm-iotcore builder has been missing for an
extended period of time. Attempts to contact the maintainer have
failed. This removes the builder until we can find a replacement
for windows-arm instances.

Fixes golang/go#38493
For golang/go#38607

Change-Id: Ia7d2168f676a86bced754688b4e2d52e61f3125b
Reviewed-on: https://go-review.googlesource.com/c/build/+/229559
Run-TryBot: Carlos Amedee <carlos@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
@toothrot
Copy link
Contributor

@toothrot toothrot commented Jun 12, 2020

Referencing #36439 as the main issue for the Windows ARM port.

@zx2c4
Copy link
Contributor

@zx2c4 zx2c4 commented Jun 12, 2020

Most of you should have received a private correspondance from me with disk images and instructions so that it's easy to launch a Windows 10 ARM64 builder on EC2/GCP from any x86 machine using qemu. If you didn't receive that from me, and you're on the Google team configuring the new builder, please pipe up.

@cagedmantis
Copy link
Contributor Author

@cagedmantis cagedmantis commented Jun 13, 2020

@zx2c4 Thank you for the disk images. We will update the corresponding issues as soon as we begin working on them.

@zx2c4
Copy link
Contributor

@zx2c4 zx2c4 commented Nov 13, 2020

I have physical ARM hardware running Windows that I would be happy to add as a builder to Go's pool.

@cagedmantis
Copy link
Contributor Author

@cagedmantis cagedmantis commented Nov 13, 2020

Note that this issue is in support of #26148

@cagedmantis
Copy link
Contributor Author

@cagedmantis cagedmantis commented Nov 13, 2020

@alexbrainman @zx2c4 While there isn't a license that permits us to run Windows arm in a virtualized environment, i'm not sure if there is any reason why contributors would not be allowed to provide builders on machines that are licensed to run this version of Windows. The previous arm builders we had were provided by Microsoft. I'm going to investigate and respond on this issue once I have an answer.

@alexbrainman
Copy link
Member

@alexbrainman alexbrainman commented Nov 14, 2020

@cagedmantis

While there isn't a license that permits us to run Windows arm in a virtualized environment,

Fair enough.

i'm not sure if there is any reason why contributors would not be allowed to provide builders on machines that are licensed to run this version of Windows.

I don't have windows arm or arm64 machine (and I never used / seen before). Let's see what @zx2c4 have. Maybe he is willing to run it as a builder.

Alex

@zx2c4
Copy link
Contributor

@zx2c4 zx2c4 commented Nov 14, 2020

As I've mentioned repeatedly, I have physical baremetal non virtualized arm64 hardware that I bought for the explicit purpose of jump starting windows/arm64 development.

@cagedmantis
Copy link
Contributor Author

@cagedmantis cagedmantis commented Nov 16, 2020

@zx2c4 Please feel free to add a builder as per https://github.com/golang/go/wiki/DashboardBuilders

@aclements
Copy link
Member

@aclements aclements commented Nov 19, 2020

Once we do have builders for this, we should make sure they have mingw-llvm installed and that its GCC compatibility wrapper is in PATH (see the comments on CL 271178).

@zx2c4
Copy link
Contributor

@zx2c4 zx2c4 commented Nov 20, 2020

Once we do have builders for this, we should make sure they have mingw-llvm installed and that its GCC compatibility wrapper is in PATH (see the comments on CL 271178).

System already configured that way :) Everything is all set, just waiting on the Go mailing list now.

@zx2c4
Copy link
Contributor

@zx2c4 zx2c4 commented Nov 20, 2020

image

Has a gcc for each environment, depending on which one you need.

@zx2c4
Copy link
Contributor

@zx2c4 zx2c4 commented Nov 20, 2020

So, specifically for here, here's the situation for the ARM builder:

image

@toothrot
Copy link
Contributor

@toothrot toothrot commented Nov 20, 2020

As I've mentioned repeatedly, I have physical baremetal non virtualized arm64 hardware that I bought for the explicit purpose of jump starting windows/arm64 development.

Jason, we've spoken over email about why there were delays. I am sorry if you found our messaging to be unclear. I would like to remind you to read over the values and code of conduct, which are available here: https://golang.org/conduct#values. Please try to be charitable in understanding that we're doing what we can.

@zx2c4
Copy link
Contributor

@zx2c4 zx2c4 commented Nov 20, 2020

Don't worry, I've always assumed that your responses have been in good faith; there's no presumption of malice.

Anyway, following the go-ahead from @cagedmantis, I've spent the last two days getting the new build server perfected and clean for this purpose, and am just waiting on the key to add it to the pool:

image

Brand new clean windows install with all the native arm tools are ready to go.

@cagedmantis
Copy link
Contributor Author

@cagedmantis cagedmantis commented Nov 20, 2020

I've responded via email with the host and private builder key.

@gopherbot
Copy link

@gopherbot gopherbot commented Nov 20, 2020

Change https://golang.org/cl/272106 mentions this issue: dashboard: add new Windows ARM builder

@dmitshur dmitshur added the arch-arm label Nov 21, 2020
gopherbot pushed a commit to golang/build that referenced this issue Nov 21, 2020
This partially reverts CL 229559, while adjusting it to use a new
builder. The builder will be used now for windows/arm and later for
windows/arm64.

Updates golang/go#42604.
Updates golang/go#38607.
Updates golang/go#36439.

Change-Id: I1ab661a6585e64de8196955c077715b32dc732b8
Reviewed-on: https://go-review.googlesource.com/c/build/+/272106
Run-TryBot: Jason A. Donenfeld <Jason@zx2c4.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Trust: Alex Brainman <alex.brainman@gmail.com>
Trust: Jason A. Donenfeld <Jason@zx2c4.com>
@gopherbot
Copy link

@gopherbot gopherbot commented Nov 28, 2020

Change https://golang.org/cl/273786 mentions this issue: dashboard: remove issue for arm builder, now that it works

@zx2c4
Copy link
Contributor

@zx2c4 zx2c4 commented Nov 28, 2020

windows/arm is back!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
7 participants