Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/compile: ssa.html sources line numbers are misaligned #38612

Closed
josharian opened this issue Apr 23, 2020 · 2 comments
Closed

cmd/compile: ssa.html sources line numbers are misaligned #38612

josharian opened this issue Apr 23, 2020 · 2 comments
Labels
Milestone

Comments

@josharian
Copy link
Contributor

@josharian josharian commented Apr 23, 2020

Reproduce: generate ssa.html for any function. Expand the sources column. Observe that that line numbers are no longer aligned with the source code. This is a regression from this cycle, I believe.

cc @bradford-hamilton

@bradford-hamilton
Copy link
Contributor

@bradford-hamilton bradford-hamilton commented Apr 23, 2020

Hey @josharian, more than happy to put some eyes on this and see whats going on.

@andybons andybons added the NeedsFix label Apr 23, 2020
@andybons andybons added this to the Go1.15 milestone Apr 23, 2020
@gopherbot
Copy link

@gopherbot gopherbot commented Apr 24, 2020

Change https://golang.org/cl/229766 mentions this issue: cmd/compile: fix misalignment in sources column of generated ssa.html

@gopherbot gopherbot closed this in d0ea533 Apr 24, 2020
xujianhai666 added a commit to xujianhai666/go-1 that referenced this issue May 21, 2020
Fix regression where line numbers in the sources column of generated
ssa.html output became misaligned with the source code. This was due
to some new margins applied to certain h2 elements during the work
to combine identical columns.

Fixes golang#38612

Change-Id: I067ccbfa30d5de5be29aab9863bc1e21f6ded128
Reviewed-on: https://go-review.googlesource.com/c/go/+/229766
Reviewed-by: Josh Bleecher Snyder <josharian@gmail.com>
Run-TryBot: Josh Bleecher Snyder <josharian@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.