Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/pkgsite: type definition links are missing in v2 packages #38613

Closed
alecthomas opened this issue Apr 23, 2020 · 1 comment
Closed

x/pkgsite: type definition links are missing in v2 packages #38613

alecthomas opened this issue Apr 23, 2020 · 1 comment
Assignees
Labels

Comments

@alecthomas
Copy link

@alecthomas alecthomas commented Apr 23, 2020

What is the URL of the page with the issue?

https://pkg.go.dev/github.com/hashicorp/hcl/v2@v2.4.0/hclsyntax?tab=doc#ParseTraversalAbs

What is your user agent?

Chrome

Screenshot

image

What did you do?

Nothing

What did you expect to see?

I expect to see the various "hcl.X" types linked to their type definitions.

What did you see instead?

They are not linked.

@gopherbot gopherbot added this to the Unreleased milestone Apr 23, 2020
@gopherbot gopherbot added the pkgsite label Apr 23, 2020
@julieqiu julieqiu added the NeedsFix label Apr 23, 2020
@julieqiu julieqiu changed the title go.dev: does not correctly link types in v2 packages go.dev: type definition links are missing in v2 packages Apr 23, 2020
@julieqiu julieqiu changed the title go.dev: type definition links are missing in v2 packages x/pkgsite: type definition links are missing in v2 packages Jun 15, 2020
@shaqque shaqque self-assigned this Jul 7, 2020
@gopherbot
Copy link

@gopherbot gopherbot commented Jul 7, 2020

Change https://golang.org/cl/241128 mentions this issue: internal/fetch/internal/doc: parse package name with major version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants