-
Notifications
You must be signed in to change notification settings - Fork 18.5k
Description
And, also, the UI is misleading, see below.
What did you do?
In Gerrit, I first run TryBots on a CL (mine or someone else)'s with "Reply" and then I click the "+1" button next to "Run-TryBot". This runs TryBots.
The TryBots run, but with errors that look probably unrelated to the CL.
Since I ran TryBots by clicking "+1" in the reply pane, "obviously" the way to do this is to reset the value to zero (the "0" is not dimmed, therefore this is permitted, right?) and then clock "+1" again (worked once, why not again?).
What did you expect to see?
A second run of the TryBots.
What did you see instead?
NOT a second run of the TryBots.
I understand that what's actually missing is that (1) we've decided that people need special permission for this operation (2) I lack this permission (3) I should know this by noticing the absence of a button that I never knew existed.
I think we ought to fix the policy unless there's a really good reason not to let people do this, and if we can't fix the policy, we need to fix the UI to avoid people intuiting an unproductive way to spend their time not rerunning TryBots. What I actually want is "Rerun failed TryBots" and ideally someone is monitoring that to infer flakiness over time.
My workaround for this is to attempt to do the rerun by hand using a gomote, which is its own fiasco of stale documentation and read-all-the-docs-maybe-you'll-find-a-hint (oops, the hint has gone stale also).
/cc @golang/osp-team