Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net/rpc: error not returned if ClientCodec.WriteRequest sleeps #38681

Open
meehow opened this issue Apr 26, 2020 · 1 comment
Open

net/rpc: error not returned if ClientCodec.WriteRequest sleeps #38681

meehow opened this issue Apr 26, 2020 · 1 comment

Comments

@meehow
Copy link

@meehow meehow commented Apr 26, 2020

What version of Go are you using (go version)?

$ go version
go version go1.14.2 linux/amd64

Does this issue reproduce with the latest release?

it is the latest release

What operating system and processor architecture are you using (go env)?

go env Output
$ go env
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/home/m/.cache/go-build"
GOENV="/home/m/.config/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOINSECURE=""
GONOPROXY=""
GONOSUMDB=""
GOOS="linux"
GOPATH="/home/m/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/snap/go/5646"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/snap/go/5646/pkg/tool/linux_amd64"
GCCGO="gccgo"
AR="ar"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build411699074=/tmp/go-build -gno-record-gcc-switches"

What did you do?

I'm trying to write custom rpc.ClientCodec
Here is simplified version: https://play.golang.org/p/T8JLIsxvhto

What did you expect to see?

I expect to see an error from WriteRequest function

What did you see instead?

(*rpc.Client).Call doesn't return an error. Error appears only when I remove time.Sleep (line 13)

@smasher164 smasher164 changed the title error from rpc.ClientCodec.WriteRequest not returned by rpc.Client.Call net/rpc: error not returned if ClientCodec.WriteRequest sleeps Apr 27, 2020
@smasher164
Copy link
Member

@smasher164 smasher164 commented Apr 27, 2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants