Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

database/sql: TestTxCannotCommitAfterRollback flake #38701

Closed
mknyszek opened this issue Apr 27, 2020 · 2 comments
Closed

database/sql: TestTxCannotCommitAfterRollback flake #38701

mknyszek opened this issue Apr 27, 2020 · 2 comments
Milestone

Comments

@mknyszek
Copy link
Contributor

@mknyszek mknyszek commented Apr 27, 2020

The test introduced by this change golang.org/cl/216240 has been flaking (albeit rarely) on both dashboard builders and trybots.

greplogs reveals:

2020-04-22T16:45:05-141b11d/windows-amd64-2008
2020-04-20T20:22:51-7004be9/windows-amd64-2008

and I have a trybot failure for an unrelated change: https://storage.googleapis.com/go-build-log/b4a5cdf0/linux-amd64-race_056b784c.log

The failure, to repeat it here, is:

--- FAIL: TestTxCannotCommitAfterRollback (0.00s)
    sql_test.go:2802: sql: no rows in result set
FAIL
FAIL	database/sql	0.724s

CC @kardianos @odeke-em

@mknyszek mknyszek added this to the Go1.15 milestone Apr 27, 2020
@kardianos
Copy link
Contributor

@kardianos kardianos commented Apr 27, 2020

Those two failures were already noted and fixed with https://go-review.googlesource.com/c/go/+/229478 .

@kardianos kardianos closed this Apr 27, 2020
@mknyszek
Copy link
Contributor Author

@mknyszek mknyszek commented Apr 27, 2020

Got it, my mistake was I only looked for open issues, and the base for my CL was a bit behind. Sorry for the noise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.