Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/internal/imports: update stdlib index after every major Go release #38706

Open
smasher164 opened this issue Apr 27, 2020 · 6 comments
Open

Comments

@smasher164
Copy link
Member

@smasher164 smasher164 commented Apr 27, 2020

API changes should automatically be detected by x/tools/internal/imports after each major release. After 1.14, they were manually updated as per #38464. This should be part of the release process (maybe x/build/cmd/releasebot?).

@gopherbot gopherbot added this to the Unreleased milestone Apr 27, 2020
@gopherbot gopherbot added the Tools label Apr 27, 2020
@gopherbot
Copy link

@gopherbot gopherbot commented Aug 4, 2020

Change https://golang.org/cl/246581 mentions this issue: internal/imports: update stdlib index for 1.15

gopherbot pushed a commit to golang/tools that referenced this issue Aug 4, 2020
    $ go run mkstdlib.go

Updates golang/go#38706.

Change-Id: I9d1bba54c4f9a0369b1d088c00a2f0c3e4409806
Reviewed-on: https://go-review.googlesource.com/c/tools/+/246581
Run-TryBot: Akhil Indurti <aindurti@gmail.com>
Run-TryBot: Heschi Kreinick <heschi@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Heschi Kreinick <heschi@google.com>
@heschik
Copy link
Contributor

@heschik heschik commented Feb 18, 2021

@golang/release might have something to say about this.

@gopherbot
Copy link

@gopherbot gopherbot commented Feb 18, 2021

Change https://golang.org/cl/293839 mentions this issue: internal/imports: update stdlib index for 1.16

@dmitshur
Copy link
Member

@dmitshur dmitshur commented Feb 18, 2021

As a first step, let's make this a recurring early-in-cycle release-blocking issue, similar to #40705 and #36905, so that this task isn't missed.

(If it's viable to automate this task so it doesn't need to be done by hand every 6 months, please file a new issue for doing that work.)

I'll place it in Go 1.17 milestone now, and when CL 293839 is submitted, it can be moved to Go 1.18.

@dmitshur dmitshur modified the milestones: Unreleased, Go1.17 Feb 18, 2021
@dmitshur dmitshur changed the title x/tools/internal/imports: automatically update stdlib index every major release x/tools/internal/imports: update stdlib index after every major Go release Feb 18, 2021
@heschik
Copy link
Contributor

@heschik heschik commented Feb 18, 2021

Strictly speaking it would probably make it sense to do it shortly before the release, once the API has stabilized. But right after is fine too.

@dmitshur dmitshur added the recurring label Feb 18, 2021
@dmitshur
Copy link
Member

@dmitshur dmitshur commented Feb 18, 2021

@heschik Yep, that makes sense. The reason I've used this early-in-cycle path for now is the same reason I closed #27155 (comment): we currently don't have a good system for tracking issues that aren't actionable until very late in a dev cycle. When we do, we can improve this task so it happens late in cycle instead.

gopherbot pushed a commit to golang/tools that referenced this issue Feb 19, 2021
    $ go run mkstdlib.go

Updates golang/go#38706.

Change-Id: I9d5bce3083d2a57eea2ea89c6a99a410ed169f05
Reviewed-on: https://go-review.googlesource.com/c/tools/+/293839
Run-TryBot: Akhil Indurti <aindurti@gmail.com>
Run-TryBot: Heschi Kreinick <heschi@google.com>
Reviewed-by: Heschi Kreinick <heschi@google.com>
Trust: Heschi Kreinick <heschi@google.com>
Trust: Hyang-Ah Hana Kim <hyangah@gmail.com>
gopls-CI: kokoro <noreply+kokoro@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
@smasher164 smasher164 modified the milestones: Go1.17, Go1.18 Feb 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants