Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls: view updates in go.mod when mod=vendor #38711

Closed
ebati opened this issue Apr 27, 2020 · 2 comments
Closed

x/tools/gopls: view updates in go.mod when mod=vendor #38711

ebati opened this issue Apr 27, 2020 · 2 comments
Labels
Milestone

Comments

@ebati
Copy link

@ebati ebati commented Apr 27, 2020

What did you do?

I just noticed updates are shown as codelens in go.mod. With go 1.14 if there is a vendor folder and go.mod file have specified go 1.14 then -mod=vendor is used automatically. This behaviour makes go list -m -u all fails, which also prevents codelens.

I think -mod=readonly can be added to here as an argument.

What did you expect to see?

Updates as codelens

What did you see instead?

Nothing

Build info

golang.org/x/tools/gopls 0.4.0
    golang.org/x/tools/gopls@v0.4.0 h1:G4+YP9kaV4dJb79J5MobyApxX493Qa6VoiTceUmxqik=
    github.com/BurntSushi/toml@v0.3.1 h1:WXkYYl6Yr3qBf1K79EBnL4mak0OimBfB0XUf9Vl28OQ=
    github.com/sergi/go-diff@v1.1.0 h1:we8PVUC3FE2uYfodKH/nBHMSetSfHDR6scGdBi+erh0=
    golang.org/x/mod@v0.2.0 h1:KU7oHjnv3XNWfa5COkzUifxZmxp1TyI7ImMXqFxLwvQ=
    golang.org/x/sync@v0.0.0-20190911185100-cd5d95a43a6e h1:vcxGaoTs7kV8m5Np9uUNQin4BrLOthgV7252N8V+FwY=
    golang.org/x/tools@v0.0.0-20200407041343-bf15fae40dea h1:DUwLyMDMUauGMd9kSLIlhhYJNELm06HuxeBdkFkeax4=
    golang.org/x/xerrors@v0.0.0-20191204190536-9bdfabe68543 h1:E7g+9GITq07hpfrRu66IVDexMakfv52eLZ2CXBWiKr4=
    honnef.co/go/tools@v0.0.1-2020.1.3 h1:sXmLre5bzIR6ypkjXCDI3jHPssRhc8KD/Ome589sc3U=
    mvdan.cc/xurls/v2@v2.1.0 h1:KaMb5GLhlcSX+e+qhbRJODnUUBvlw01jt4yrjFIHAuA=

Go info

go version go1.14.2 darwin/amd64
@gopherbot gopherbot added this to the Unreleased milestone Apr 27, 2020
@gopherbot gopherbot added the Tools label Apr 27, 2020
@gopherbot
Copy link

@gopherbot gopherbot commented Apr 27, 2020

Thank you for filing a gopls issue! Please take a look at the Troubleshooting guide, and make sure that you have provided all of the relevant information here.

@gopherbot gopherbot added the gopls label Apr 27, 2020
@stamblerre stamblerre modified the milestones: Unreleased, gopls/v0.5.0 Apr 27, 2020
@gopherbot
Copy link

@gopherbot gopherbot commented May 6, 2020

Change https://golang.org/cl/232477 mentions this issue: internal/lsp/cache: show update codelens in go.mod when -mod=vendor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.