Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
x/tools/gopls: sudden errors in unrelated files #38730
What did you do?
Edited code in a single test file in VSCode.
What did you expect to see?
Only my current file should be affected by changes in a test package.
What did you see instead?
Suddenly, a large number of unrelated files were marked as having errors. I did not have any of these files open, nor did I change them, nor did (as far as I know) any program on my computer touch them. All the errors in them are spurious; restarting gopls causes them to go away.
Log: gopls.log.gz. This is from gopls started, so fairly large. Jump to line 14890 to see what looks like the first error.
Note: While I have
Thanks for clarifying. Tests can still be dependencies (if this is an in-package test, and not an x_test) because other test packages depend on test variants. It's possible that we have another cache invalidation issue with test variants, but I'm not sure how that could've happened since it's been a while since the type-checking code has changed.
I think I will close this issue as a duplicate of #38403 so that we can track everything in one place. Please comment there if you're able to find a consistent repro for this.
We tend to follow the same style in issues and commit messages - see https://github.com/golang/go/wiki/CommitMessage.