Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
GitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
net/http: apparent deadlock in TestSOCKS5Proxy on plan9-arm builder #38769
This looks like a possible deadlock involving the network poller on Plan 9:
Here's a possibly related clue: I'm monitoring a test machine now which seems to have deadlocked in the x/net/http2 test, and the last message on the system console is:
It may be that too many simultaneous connection attempts are causing some to be dropped. I would have expected an error condition that the test would notice, not a deadlock, but I'll see if increasing the queue size helps.
There are data races on fd.[rw]aio and fd.[rw]timedout when Read/Write is called on a polled fd concurrently with SetDeadline (see #38769). Adding a mutex around accesses to each pair (read and write) prevents the race, which was causing deadlocks in net/http tests on the builders. Updates #38769. Change-Id: I31719b3c9a664e81a775cda583cff31c0da946c4 Reviewed-on: https://go-review.googlesource.com/c/go/+/235820 Run-TryBot: David du Colombier <email@example.com> TryBot-Result: Gobot Gobot <firstname.lastname@example.org> Reviewed-by: David du Colombier <email@example.com>