Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build: dragonfly-amd64-5_8 does not have SSH configured #38796

Closed
andybons opened this issue May 1, 2020 · 17 comments
Closed

x/build: dragonfly-amd64-5_8 does not have SSH configured #38796

andybons opened this issue May 1, 2020 · 17 comments
Assignees
Milestone

Comments

@andybons
Copy link
Member

@andybons andybons commented May 1, 2020

This is needed for gomote configurations.

@tuxillo @bcmills

@gopherbot gopherbot added this to the Unreleased milestone May 1, 2020
@gopherbot gopherbot added the Builders label May 1, 2020
@tuxillo
Copy link

@tuxillo tuxillo commented May 1, 2020

what's exactly needed?

@bcmills
Copy link
Member

@bcmills bcmills commented May 1, 2020

@bcmills
Copy link
Member

@bcmills bcmills commented May 1, 2020

It appears to need SSH public-key authentication for some user (typically either gopher or root), with the username configured in golang.org/x/build/dashboard/builders.go. I assume @andybons can get you the public key.

@bcmills
Copy link
Member

@bcmills bcmills commented May 1, 2020

Or, if you'd prefer to diagnose #38797 yourself, that would work too. 😉

@tuxillo
Copy link

@tuxillo tuxillo commented May 1, 2020

If you provide the public key I can add it to the root user.

@andybons andybons self-assigned this May 1, 2020
@andybons
Copy link
Member Author

@andybons andybons commented May 1, 2020

@tuxillo is there a builder key present on the host per step 1 of https://github.com/golang/go/wiki/DashboardBuilders#how-to-set-up-a-builder ? (don’t paste it here)

@tuxillo
Copy link

@tuxillo tuxillo commented May 1, 2020

Yes, sure. Otherwise it would not even connect as far as I can tell:

# ls -l ~/.gobuildkey-host-dragonfly-amd64-5_8
-rw-r--r--  1 root  wheel  33 Apr 14 16:37 /root/.gobuildkey-host-dragonfly-amd64-5_8
@dmitshur
Copy link
Member

@dmitshur dmitshur commented May 1, 2020

what's exactly needed?

The host config for the dragonfly-amd64-5_8 builder has the empty string value for the SSHUsername field in the golang.org/x/build/dashboard package:

https://github.com/golang/build/blob/916311cec4e1738aae572fe49767cebdc0351144/dashboard/builders.go#L363-L369

The empty string means "disable SSH access on this builder".

It needs to be set to a non-empty value, then coordinator needs to be redeployed. (Maybe more will need to be done afterwards.)

@andybons andybons assigned dmitshur and unassigned andybons May 4, 2020
@dmitshur
Copy link
Member

@dmitshur dmitshur commented May 5, 2020

@tuxillo Could you please send a CL that updates the SSHUsername field in the x/build/dashboard package and add me as a reviewer? Thank you.

/cc @bradfitz Do you know if there are any tasks to do on the side of the reverse builder (by the builder owner) when enabling SSH access?

@dmitshur dmitshur added the NeedsFix label May 5, 2020
@bradfitz
Copy link
Contributor

@bradfitz bradfitz commented May 5, 2020

The buildlet binary is responsible for editing the authorized_keys file on the host. Finding the path to the appropriate file has needed some tweaks for different OSes over time. It's likely to work automatically on DragonFly at this point but if not, that's the place to look.

@dmitshur
Copy link
Member

@dmitshur dmitshur commented May 5, 2020

Thanks Brad.

@tuxillo If it's helpful to you, I can create the CL and make you a reviewer, but you'll need to tell me what username I should specify for your builder. Let me know how you'd like to proceed. Thanks.

@bradfitz
Copy link
Contributor

@bradfitz bradfitz commented May 5, 2020

IIRC it needs to be the user that runs the builder. The main reason it's not automatic is that some builder owners don't want to permit SSH into their network.

@tuxillo
Copy link

@tuxillo tuxillo commented May 5, 2020

The DragonFly builders run in VMs so the user will be root.

@dmitshur I'll create the PR.

@gopherbot
Copy link

@gopherbot gopherbot commented May 5, 2020

Change https://golang.org/cl/232337 mentions this issue: dashboard: enable SSH access in DragonFly BSD builders

@tuxillo
Copy link

@tuxillo tuxillo commented May 5, 2020

Let me know if anything else is needed on my side.

@dmitshur dmitshur reopened this May 5, 2020
@dmitshur
Copy link
Member

@dmitshur dmitshur commented May 5, 2020

Will do, thanks. Re-opening to track coordinator deployment.

@dmitshur
Copy link
Member

@dmitshur dmitshur commented May 6, 2020

Coordinator is re-deployed, and I've verified that it's possible to ssh into a dragonfly-amd64-5_8 gomote instance now. /cc @bcmills

@dmitshur dmitshur closed this May 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

6 participants
You can’t perform that action at this time.