Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls: fail early in completion when possible #38868

Closed
stamblerre opened this issue May 5, 2020 · 1 comment
Closed

x/tools/gopls: fail early in completion when possible #38868

stamblerre opened this issue May 5, 2020 · 1 comment

Comments

@stamblerre
Copy link
Contributor

@stamblerre stamblerre commented May 5, 2020

I just noticed that ErrIsDefinition is returned for completions on L568 of internal/lsp/source/completion.go. This is pretty deep into the completion logic for something that we should be able to detect and return as an error right away.

@stamblerre stamblerre added this to the gopls/v0.5.0 milestone May 5, 2020
@gopherbot
Copy link

@gopherbot gopherbot commented May 7, 2020

Change https://golang.org/cl/232677 mentions this issue: internal/lsp: return early in completion where possible

@stamblerre stamblerre modified the milestones: gopls/v0.5.0, gopls/v0.4.1 May 13, 2020
@golang golang locked and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants