Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
x/tools/gopls: suddenly stops working #38878
Edited code in a single file. Gopls suddenly stopped reporting any errors. I could not get gopls to function again, and had to reload. Unfortunately, I could not reproduce the problem even when I went through the same editing steps that I remembered.
gopls.log. Note: Scrubbed of
From what I can tell in your log, it looks like you switched branches, which caused
When a file with errors is removed outside the editor, sometimes its errors are cleared by the editor and sometimes they are not. If the file is still open in the editor gopls does not clear the errors, taking the editor's version as the truth. Otherwise the errors are cleared. (This behavior depends on the editor sending gopls a notification that the workspace changed.) There seems to be no good way yet to test that gopls takes no action after receiving the didChangeWatchedFiles notification. Updates golang/go#38878 Change-Id: Ie418dd786d4c5f827cf0665a31f0f9913f7cfdc0 Reviewed-on: https://go-review.googlesource.com/c/tools/+/235377 Run-TryBot: Peter Weinberger <email@example.com> TryBot-Result: Gobot Gobot <firstname.lastname@example.org> Reviewed-by: Robert Findley <email@example.com>
This test partially reproduces some strange behavior with creating new tests files. In particular, it creates a new x test in a package that already has a test variant and adds content with a missing import. In the test, the import is never added. However, in my own experience debugging this in VS Code, I see the import get added but the diagnostic never get removed. One thing at a time though... Updates golang/go#39315 Change-Id: I724a145688b915d04abd1f21efc6f9a7506be043 Reviewed-on: https://go-review.googlesource.com/c/tools/+/235581 Run-TryBot: Rebecca Stambler <firstname.lastname@example.org> TryBot-Result: Gobot Gobot <email@example.com> Reviewed-by: Heschi Kreinick <firstname.lastname@example.org>