Skip to content

/ go

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net/http: dead link to chrome documentation on connection management #38885

Closed
smasher164 opened this issue May 5, 2020 · 1 comment
Closed

net/http: dead link to chrome documentation on connection management #38885

smasher164 opened this issue May 5, 2020 · 1 comment
Labels
Documentation NeedsFix

Comments

@smasher164
Copy link
Member

@smasher164 smasher164 commented May 5, 2020

go/src/net/http/transport.go

Lines 843 to 846 in 8627b4c

// Deliver pconn to goroutine waiting for idle connection, if any.
// (They may be actively dialing, but this conn is ready first.
// Chrome calls this socket late binding.
// See https://insouciant.org/tech/connection-management-in-chromium/.)

https://insouciant.org/tech/connection-management-in-chromium/ is no longer accessible. The relevant docs should point to the chromium wiki at https://www.chromium.org/developers/design-documents/network-stack#TOC-Connection-Management.
@gopherbot
Copy link

@gopherbot gopherbot commented May 5, 2020

Change https://golang.org/cl/232357 mentions this issue: net/http: update link to chrome documentation on connection management
@gopherbot gopherbot closed this in 0e617d3 May 5, 2020
xujianhai666 added a commit to xujianhai666/go-1 that referenced this issue May 21, 2020
@smasher164 @xujianhai666
net/http: update link to chrome documentation on connection management
fb312f2 
The previous link at
https://insouciant.org/tech/connection-management-in-chromium/ is no
longer accessible. This CL changes it to
https://www.chromium.org/developers/design-documents/network-stack#TOC-Connection-Management.

Fixes golang#38885.

Change-Id: I0881e72fe0c099294ab137b5e2d0c3f5763978f8
Reviewed-on: https://go-review.googlesource.com/c/go/+/232357
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Documentation NeedsFix
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@gopherbot @smasher164