Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/present: no section headers in Markdown syntax #38926

Open
jadekler opened this issue May 7, 2020 · 4 comments
Open

x/tools/present: no section headers in Markdown syntax #38926

jadekler opened this issue May 7, 2020 · 4 comments

Comments

@jadekler
Copy link
Member

@jadekler jadekler commented May 7, 2020

IIRC we used to be able to use * and ** for section and subsection headers. It appears as though that's no longer the case: # terminates the content [1] (without an error...?), and ## is a subsection header.

Not sure if this is a bug or feature request.

1: As in, no header is displayed and no content is displayed after that point.

@gopherbot gopherbot added this to the Unreleased milestone May 7, 2020
@jadekler
Copy link
Member Author

@jadekler jadekler commented May 7, 2020

@tbpg points out that https://go.googlesource.com/tools/+/refs/heads/master/present/parse.go#381 might be where this "stop reading more content" happens. (if I interpreted correctly)

@dmitshur
Copy link
Member

@dmitshur dmitshur commented May 8, 2020

Thanks for reporting @jadekler.

Is this about the new Markdown syntax or the legacy present syntax? The Markdown syntax was recently added in #33955.

@jadekler
Copy link
Member Author

@jadekler jadekler commented May 11, 2020

The new markdown!

@dmitshur dmitshur changed the title x/blog: no section headers anymore x/tools/present: no section headers in Markdown syntax May 11, 2020
@dmitshur
Copy link
Member

@dmitshur dmitshur commented May 11, 2020

/cc @rsc per owners.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.