Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls: issue with named imports #38927

Closed
stamblerre opened this issue May 7, 2020 · 4 comments
Closed

x/tools/gopls: issue with named imports #38927

stamblerre opened this issue May 7, 2020 · 4 comments
Labels
Milestone

Comments

@stamblerre
Copy link
Contributor

@stamblerre stamblerre commented May 7, 2020

See the repro case here: https://github.com/atombender/gopls-issue-38403.

/cc @atombender

@heschik
Copy link
Contributor

@heschik heschik commented May 8, 2020

I reduced the test case to these two files:

package mypkg

func One() {
}
package mypkg

import net_url "net/url"

func Two() *net_url.URL {
	return nil
}

One significant finding: if you save the second file while it's got the error, it actually gets rewritten to *url.URL. That strongly hints that the AST is getting messed with, possibly by an analyzer.

@heschik
Copy link
Contributor

@heschik heschik commented May 8, 2020

@gopherbot
Copy link

@gopherbot gopherbot commented May 8, 2020

Change https://golang.org/cl/232990 mentions this issue: internal/lsp/source: fix cloneExpr for SelectorExprs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.