Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build: ensure that the coordinator attempts to connect with the buildlet for 5 minutes #38956

Closed
cagedmantis opened this issue May 8, 2020 · 1 comment

Comments

@cagedmantis
Copy link
Contributor

@cagedmantis cagedmantis commented May 8, 2020

When a VM instance is created, the coordinator should attempt to connect to the buildlet for either 5 minutes or the timeout of the context passed to the buildletClient function.

After change golang/build@372ecfe, the buildlet client will only attempt to connect for 5 seconds before failing to create a buildlet client.

/cc @dmitshur @toothrot @andybons

@gopherbot
Copy link

@gopherbot gopherbot commented May 8, 2020

Change https://golang.org/cl/232997 mentions this issue: buildlet: ensure buildlet client creation timeout is correct

@golang golang locked and limited conversation to collaborators May 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants