Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build/cmd/gopherbot: for repos not mirrored to GitHub, close issues listed under "Fixes" when CL is submitted (to an active branch) #38961

Open
thanm opened this issue May 8, 2020 · 5 comments

Comments

@thanm
Copy link
Member

@thanm thanm commented May 8, 2020

I recently sent a series of CLs (ending with https://golang.org/cl/232742) to fix a gollvm bug, #38728.

Gopherbot noticed the CLs as they were put up, adding "mentioned" notices to the issue:

Change https://golang.org/cl/232742 mentions this issue: gollvm: add workaround for hard-wired cf-protection=branch

however when the CLs were merged, it didn't take any actions. In particular the bot didn't annotate the issue with the merge, and didn't auto-close the bug.

Wondering if there is something I did wrong with the CLs (I used the usual "Updates/Fixes" notation), or if there is something else gumming up the works?

Any pointers appreciated. Thanks.

@gopherbot gopherbot added this to the Unreleased milestone May 8, 2020
@thanm
Copy link
Member Author

@thanm thanm commented May 8, 2020

@cherrymui
Copy link
Contributor

@cherrymui cherrymui commented May 8, 2020

I think this is because gollvm is only on Gerrit, not mirrored to GitHub.

@thanm
Copy link
Member Author

@thanm thanm commented May 8, 2020

Ah. OK, I will keep that in mind.

@toothrot
Copy link
Contributor

@toothrot toothrot commented May 11, 2020

/cc @cagedmantis (and me)

@dmitshur
Copy link
Contributor

@dmitshur dmitshur commented May 11, 2020

I believe @cherrymui's analysis in #38961 (comment) is accurate. The gollvm repo isn't mirrored to GitHub, so we can't rely on issues getting closed automatically by GitHub when the corresponding commit is pushed to GitHub by gitmirror.

Instead, gopherbot needs to close the corresponding issue by using the GitHub API directly. We already have logic in gopherbot to do this for issues that are merged to non-master branches, see here.

Another relevant issue here is #29599 (comment). It's likely we need to resolve that before we can implement this, otherwise gopherbot would close not only issue mentioned in "Fixes #​123", but also in "Updates #​456" lines.

@dmitshur dmitshur changed the title x/build/cmd/gopherbot: no auto-close for after "fix" CL submitted x/build/cmd/gopherbot: for repos not mirrored to GitHub, close issues listed under "Fixes" when CL is submitted (to an active branch) May 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants