x/build/cmd/gopherbot: for repos not mirrored to GitHub, close issues listed under "Fixes" when CL is submitted (to an active branch)

[thanm]

I recently sent a series of CLs (ending with https://golang.org/cl/232742) to fix a gollvm bug, #38728.

Gopherbot noticed the CLs as they were put up, adding "mentioned" notices to the issue:

Change https://golang.org/cl/232742 mentions this issue: gollvm: add workaround for hard-wired cf-protection=branch

however when the CLs were merged, it didn't take any actions. In particular the bot didn't annotate the issue with the merge, and didn't auto-close the bug.

Wondering if there is something I did wrong with the CLs (I used the usual "Updates/Fixes" notation), or if there is something else gumming up the works?

Any pointers appreciated. Thanks.

[thanm]

@dmitshur @andybons

[cherrymui]

I think this is because gollvm is only on Gerrit, not mirrored to GitHub.

[thanm]

Ah. OK, I will keep that in mind.

[toothrot]

/cc @cagedmantis (and me)

[dmitshur]

I believe @cherrymui's analysis in #38961 (comment) is accurate. The gollvm repo isn't mirrored to GitHub, so we can't rely on issues getting closed automatically by GitHub when the corresponding commit is pushed to GitHub by gitmirror.

Instead, gopherbot needs to close the corresponding issue by using the GitHub API directly. We already have logic in gopherbot to do this for issues that are merged to non-master branches, see here.

Another relevant issue here is #29599 (comment). It's likely we need to resolve that before we can implement this, otherwise gopherbot would close not only issue mentioned in "Fixes #​123", but also in "Updates #​456" lines.

[katiehockman]

I think we're running into this issue on the dev.fuzz branch. See #46633 (comment) and #46632 which we would have expected to be closed when they were merged since they have the Fixes #XXXXX line, but were not.