Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/crypto/acme: support subproblems #38978

Closed
mbaynton opened this issue May 10, 2020 · 5 comments · May be fixed by golang/crypto#138
Closed

x/crypto/acme: support subproblems #38978

mbaynton opened this issue May 10, 2020 · 5 comments · May be fixed by golang/crypto#138

Comments

@mbaynton
Copy link

@mbaynton mbaynton commented May 10, 2020

What version of Go are you using (go version)?

$ go version
go version go1.13 linux/amd64

Does this issue reproduce with the latest release?

Yes

What operating system and processor architecture are you using (go env)?

go env Output
$ go env
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/home/mpantheon/.cache/go-build"
GOENV="/home/mpantheon/.config/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GONOPROXY=""
GONOSUMDB=""
GOOS="linux"
GOPATH="/home/mpantheon/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/usr/local/go"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/local/go/pkg/tool/linux_amd64"
GCCGO="gccgo"
AR="ar"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build487582068=/tmp/go-build -gno-record-gcc-switches"

What did you do?

Called AuthorizeOrder to request a new ACMEv2 Order with identifiers rejected by the CA

What did you expect to see?

An acme.Error populated with RFC 8555 subproblems

What did you see instead?

An acme.Error with no subproblems available.

This limits the information clients can provide to users and prevents automated corrections to the invalid Order, such as by removing the the rejected identifiers and requesting a new Order.

@gopherbot gopherbot added this to the Unreleased milestone May 10, 2020
@gopherbot
Copy link

@gopherbot gopherbot commented May 10, 2020

Change https://golang.org/cl/233165 mentions this issue: x/crypto/acme: add support for subproblems

@toothrot
Copy link
Contributor

@toothrot toothrot commented May 11, 2020

@rolandshoemaker rolandshoemaker changed the title x/crypto/acme: Unmarshal RFC 8555 subproblems proposal: x/crypto/acme: support subproblems Mar 30, 2021
@rolandshoemaker
Copy link
Member

@rolandshoemaker rolandshoemaker commented Mar 30, 2021

Since this changes an API, marking it as a proposal.

CL 233165 proposes the following API addition/change:

type Subproblem struct {
	Type        string
	Detail      string
	Instance    string
	Identifier  *AuthzID
}

func (sp Subproblem) String() string

type Error struct {
	...
	Subproblems []Subproblem
}
@rolandshoemaker rolandshoemaker added this to Incoming in Proposals Mar 30, 2021
@rsc rsc moved this from Incoming to Active in Proposals Mar 31, 2021
@rsc
Copy link
Contributor

@rsc rsc commented Apr 7, 2021

Based on the discussion above, this proposal seems like a likely accept.
— rsc for the proposal review group

@rsc rsc moved this from Active to Likely Accept in Proposals Apr 7, 2021
@rsc rsc moved this from Likely Accept to Accepted in Proposals Apr 14, 2021
@rsc
Copy link
Contributor

@rsc rsc commented Apr 14, 2021

No change in consensus, so accepted. 🎉
This issue now tracks the work of implementing the proposal.
— rsc for the proposal review group

@rsc rsc changed the title proposal: x/crypto/acme: support subproblems x/crypto/acme: support subproblems Apr 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Proposals
Accepted
Linked pull requests

Successfully merging a pull request may close this issue.

5 participants