Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build/cmd/gopherbot: generalize issue gardening tasks to work on all subrepos #39008

Open
stamblerre opened this issue May 11, 2020 · 5 comments
Open

Comments

@stamblerre
Copy link
Contributor

@stamblerre stamblerre commented May 11, 2020

Some of the subrepos maintain their own issue trackers, so it would be useful to have the general issue gardening tasks work on the subrepos. I've narrowed these tasks down to:

  • Freezing old issues and closing issues in the WaitingForInfo state
  • Automatically labeling proposals and documentation issues
  • Applying labels from comments
@gopherbot
Copy link

@gopherbot gopherbot commented May 11, 2020

Change https://golang.org/cl/233377 mentions this issue: cmd/gopherbot: extend gopherbot's general tasks to all subrepos

@dmitshur dmitshur changed the title cmd/gopherbot: generalize issue gardening tasks to work on all subrepos x/build/cmd/gopherbot: generalize issue gardening tasks to work on all subrepos May 11, 2020
@gopherbot gopherbot added this to the Unreleased milestone May 11, 2020
@dmitshur
Copy link
Contributor

@dmitshur dmitshur commented May 11, 2020

The general direction seems reasonable to me. We need to be mindful of all the issue trackers and issues that will be retroactively affected. I think it should be better to roll out any changes here gradually, to avoid the thundering herd problem and to make it easier to review what's being modified.

Are you okay with rolling this out for vscode-go issue tracker first, before we take on other repos? Since you and @hyangah are its owners, it should be easier to make progress on that repo (and for you to tell whether gopherbot is acting in a helpful way and not causing disruption).

/cc @golang/osp-team

@stamblerre
Copy link
Contributor Author

@stamblerre stamblerre commented May 11, 2020

Makes sense. I made that adjustment in the CL.

gopherbot pushed a commit to golang/build that referenced this issue May 15, 2020
GopherBot has a few tasks, such as automatically applying labels and
closing stale issues, which are applicable to all golang.org/x repos,
not just golang/go. This change makes these work for golang/go and
golang/vscode-go, with the eventual intention of making them work for
more repos.

Updates golang/go#39008

Change-Id: I4aad54822422747aeac25590de3069562bebb3a5
Reviewed-on: https://go-review.googlesource.com/c/build/+/233377
Run-TryBot: Rebecca Stambler <rstambler@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
@gopherbot
Copy link

@gopherbot gopherbot commented May 15, 2020

Change https://golang.org/cl/234023 mentions this issue: cmd/gopherbot: print referenced repo in closeCherryPickIssues

gopherbot pushed a commit to golang/build that referenced this issue May 15, 2020
Calls to addGitHubComment and closeGitHubIssue operate on ref.Repo.ID(),
so use it in printIssue call too, rather than hard-coding b.gorepo.ID().

There's no change in behavior now because the closeCherryPickIssues task
only closes issues in the main Go repository at this time, but it should
prevent confusion if that changes in the future.

For golang/go#39008.

Change-Id: Idb72eb884a917ce1eb4d9cc7fb6114e52ddee9db
Reviewed-on: https://go-review.googlesource.com/c/build/+/234023
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Rebecca Stambler <rstambler@golang.org>
@gopherbot
Copy link

@gopherbot gopherbot commented Apr 9, 2021

Change https://golang.org/cl/308790 mentions this issue: cmd/gopherbot: add more deleted issues to deletedIssues map

gopherbot pushed a commit to golang/build that referenced this issue Apr 9, 2021
A good amount of time has passed since the deletedIssues map was last
updated, and the "freeze old issues" task was needlessly making 34 API
calls to freeze issues that are gone. After this change, that task is
making 0 API calls (whenever there aren't existing issues to freeze).

Some gardening tasks were converted to be more general and run on more
issue trackers in CL 233377, so update the deletedIssues map to track
the repo ID in addition to the issue number.

For golang/go#28320.
Updates golang/go#22635.
Updates golang/go#44406.
Updates golang/go#39008.

Change-Id: I3b477bf717f7d97676e9ef950214a3598ec3abd2
Reviewed-on: https://go-review.googlesource.com/c/build/+/308790
Trust: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Carlos Amedee <carlos@golang.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants