Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/pkgsite: support definition jumping for repositories from gitea.com or other gitea instances #39019

Open
lunny opened this issue May 12, 2020 · 7 comments
Labels
Milestone

Comments

@lunny
Copy link

@lunny lunny commented May 12, 2020

I noticed that repositories from https://gitea.com (i.e. https://pkg.go.dev/xorm.io/xorm ) have no definition jumping but repositories from github have. I would like to send a PR to fix this but cannot find the sources of pkg.go.dev . Any chance to do that?

@gopherbot gopherbot added this to the Unreleased milestone May 12, 2020
@gopherbot gopherbot added the pkgsite label May 12, 2020
@lunny lunny changed the title go.dev: Support definition jumping for repositories from gitea.com go.dev: Support definition jumping for repositories from gitea.com or other gitea instances May 12, 2020
@julieqiu
Copy link
Contributor

@julieqiu julieqiu commented May 14, 2020

Thanks for the feedback! We are working on open sourcing the codebase (#36747) and would love to receive a contribution from you once that is done.

@julieqiu julieqiu added the NeedsFix label May 14, 2020
@julieqiu julieqiu changed the title go.dev: Support definition jumping for repositories from gitea.com or other gitea instances go.dev: support definition jumping for repositories from gitea.com or other gitea instances May 14, 2020
@lunny
Copy link
Author

@lunny lunny commented May 15, 2020

@julieqiu Will try that after it becomes open source.

@julieqiu julieqiu changed the title go.dev: support definition jumping for repositories from gitea.com or other gitea instances x/pkgsite: support definition jumping for repositories from gitea.com or other gitea instances Jun 15, 2020
@jba
Copy link
Contributor

@jba jba commented Jun 19, 2020

Part of the problem is with gitea itself. See the end of #39559 (comment), specifically "there is no template that will work with the abbreviated hash at the end of a pseudo-version." If you are a gitea maintainer or know one, we could use some help with that.

@lunny
Copy link
Author

@lunny lunny commented Jun 20, 2020

@jba I'm the founder of Gitea, Thanks for your reply. I will follow your link.

@jba
Copy link
Contributor

@jba jba commented Jul 28, 2020

@lunny Is there a bug we can point to for adding short hashes to gitea?

@gopherbot
Copy link

@gopherbot gopherbot commented Jul 28, 2020

Change https://golang.org/cl/245259 mentions this issue: internal/source: support more code-hosting sites

gopherbot pushed a commit to golang/pkgsite that referenced this issue Jul 28, 2020
Suport git.fd.io, fit.pirl.io, and gitea.

For golang/go#39019

Change-Id: I4e4fbf617598435803d209fc6150b7c8e56a0f72
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/245259
Reviewed-by: Julie Qiu <julie@golang.org>
@lunny
Copy link
Author

@lunny lunny commented Jul 31, 2020

@jba There is a PR to do that go-gitea/gitea#6452 but not merged yet. And thanks for your cl.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.