Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls: bad edits for go.mod #39041

Open
stamblerre opened this issue May 13, 2020 · 0 comments
Open

x/tools/gopls: bad edits for go.mod #39041

stamblerre opened this issue May 13, 2020 · 0 comments
Labels
Milestone

Comments

@stamblerre
Copy link
Contributor

@stamblerre stamblerre commented May 13, 2020

Repro case:

-- mod/go.mod --
module mod.com

go 1.14

require google.golang.org/protobuf v1.20.0
-- mod/main.go --
package main

import (
    "github.com/esimov/caire"
)

func _() {
    caire.RemoveTempImage()
}

There should be a diagnostic warning that "github.com/esimov/caire" is not in the go.mod file. Accepting the associated suggested fix will result in a go.mod file that looks like:

module mod.com

go 1.14

require (
	""
	github.com/esimov/caire v1.2.5
)
@stamblerre stamblerre added this to the gopls/v0.5.0 milestone May 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.