Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls: decide if import statements should have definitions or links #39065

Open
stamblerre opened this issue May 14, 2020 · 0 comments
Open
Labels
Milestone

Comments

@stamblerre
Copy link
Contributor

@stamblerre stamblerre commented May 14, 2020

See microsoft/vscode-go#2614 for more context.

Ctrl + Click in VS Code is a shortcut for both jump to definition and opening a link. We provide links to https://pkg.go.dev for import statements, as well as definitions in the form of opening a window that shows the files in the package. The behavior is unintuitive because 2 things happen at once.

Currently, users can disable document links through the go.experimentalLanguageServerFeatures setting. Based on the response to microsoft/vscode#81520, my guess is that VS Code will not be fixing this any time soon, and even if they did, the only correct fix would be to change one of their shortcuts. Users are probably used to things working a specific way, so I doubt they would change a default shortcut, particularly since, in the majority of cases, definitions and document links don't collide.

I propose that we create a gopls setting to choose between links and definitions for import statements. The default could be both. This way, users will not lose document links for other cases in which there are no collisions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.