Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/pkgsite: support removing packages in the top-level module, but not in nested modules #39103

Open
bogdandrutu opened this issue May 15, 2020 · 4 comments

Comments

@bogdandrutu
Copy link

@bogdandrutu bogdandrutu commented May 15, 2020

What is the URL of the page with the issue?

https://pkg.go.dev/mod/go.opentelemetry.io?tab=packages

What did you do?

Initially using https://github.com/GoogleCloudPlatform/govanityurls.git we publish modules directly under go.opentelemetry.io but later because we found that we will have more repos we decided to use different paths to export different repositories

/otel:
  repo: https://github.com/open-telemetry/opentelemetry-go
/collector:
  repo: https://github.com/open-telemetry/opentelemetry-collector
/contrib/otel:
  repo: https://github.com/open-telemetry/opentelemetry-go-contrib
/contrib/collector:
  repo: https://github.com/open-telemetry/opentelemetry-collector-contrib

Before we had (which we replaced 6 moths ago, and never used):

/:
  repo: https://github.com/open-telemetry/opentelemetry-go

What did you expect to see?

I would expect all the old packages that we exported previously https://pkg.go.dev/mod/go.opentelemetry.io?tab=packages to be gone.

What did you see instead?

I would expect to have only packages under https://pkg.go.dev/mod/go.opentelemetry.io/otel?tab=packages

@ALTree
Copy link
Member

@ALTree ALTree commented May 17, 2020

@julieqiu
Copy link
Contributor

@julieqiu julieqiu commented May 19, 2020

At the moment, we exclude packages based on having a shared path prefix, so removing go.opentelemetry.io would remove all packages with that prefix, including the ones in go.opentelemetry.io/otel.

We can work on a fix for this so that it is on a module level.

@julieqiu julieqiu added the NeedsFix label May 19, 2020
@julieqiu julieqiu changed the title go.dev: Help removing packages under go.opentelemetry.io go.dev: support removing packages in top-level module, but not nested modules May 19, 2020
@julieqiu julieqiu changed the title go.dev: support removing packages in top-level module, but not nested modules go.dev: support removing packages in the top-level module, but not in nested modules May 19, 2020
@bogdandrutu
Copy link
Author

@bogdandrutu bogdandrutu commented May 20, 2020

Thank you @julieqiu

@julieqiu julieqiu changed the title go.dev: support removing packages in the top-level module, but not in nested modules x/pkgsite: support removing packages in the top-level module, but not in nested modules Jun 15, 2020
@bogdandrutu
Copy link
Author

@bogdandrutu bogdandrutu commented Jul 30, 2020

@julieqiu any update on this? Thank you so much for your help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.