Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/mobile, x/exp: build failing due to link errors on linux-386-longtest builder #39156

Closed
bcmills opened this issue May 20, 2020 · 5 comments
Closed

Comments

@bcmills
Copy link
Member

@bcmills bcmills commented May 20, 2020

2020-03-29T12:56:38-4c31acb/linux-386-longtest

# golang.org/x/mobile/gl
/usr/bin/ld: cannot find -lGLESv2
collect2: error: ld returned 1 exit status
# golang.org/x/mobile/exp/audio/al
/usr/bin/ld: cannot find -lopenal
/usr/bin/ld: cannot find -lopenal
collect2: error: ld returned 1 exit status
FAIL	golang.org/x/mobile/app [build failed]

This is likely a side-effect of CL 234520 (CC @dmitshur @toothrot @cagedmantis).

@dmitshur
Copy link
Contributor

@dmitshur dmitshur commented May 20, 2020

This is affecting x/exp too (because it uses x/mobile/gl).

All other 32-bit linux builders (linux-386, linux-386-387, linux-386-clang, linux-386-sid) are disabled on both x/mobile and x/exp repos. Both are experimental, so not supporting 32-bit seems reasonable. Perhaps we should do the same for linux-386-longtest?

@gopherbot, please add NeedsDecision.

/cc @hyangah @hajimehoshi

@dmitshur dmitshur changed the title x/mobile: build failing due to link errors on linux-386-longtest builder x/mobile, x/exp: build failing due to link errors on linux-386-longtest builder Jun 5, 2020
@dmitshur
Copy link
Contributor

@dmitshur dmitshur commented Jun 5, 2020

I think a reasonable next step here is to disable the linux-386-longtest builder on the x/mobile and x/exp repositories.

If it's determined that those repositories should support linux/386, then we should fix the known failures, and then re-enable both linux-386 and linux-386-longtest builders.

@gopherbot, please add NeedsFix and remove NeedsDecision.

@hajimehoshi
Copy link
Member

@hajimehoshi hajimehoshi commented Jun 6, 2020

The error seems like a test environment issue rather than Go compiler's issue.

@dmitshur dmitshur self-assigned this Jun 20, 2020
@gopherbot
Copy link

@gopherbot gopherbot commented Jul 1, 2020

Change https://golang.org/cl/240512 mentions this issue: dashboard: stop linux-386-longtest builds in x/exp and x/mobile

@gopherbot
Copy link

@gopherbot gopherbot commented Jul 1, 2020

Change https://golang.org/cl/240687 mentions this issue: dashboard: document and clarify defaultBuildsRepoPolicy

@gopherbot gopherbot closed this in dd5ac55 Jul 1, 2020
gopherbot pushed a commit to golang/build that referenced this issue Jul 7, 2020
The defaultBuildsRepoPolicy function was very important in that any
changes to it would affect many builders, but it was not documented
well.

This refactor attempts to improve the situation. It turned out better
to also rename defaultBuildsRepoPolicy to buildRepoByDefault and limit
its scope to report whether a given repo should be built by default.
The branch and goBranch parameters were never used, and thus misleading.
If they're needed in the future, we can easily re-add them.

The name defaultBuildsRepoPolicy made it sound as if it was the entire
"builds repo" policy, bun reality most of the policy is implemented in
the BuildConfig.buildsRepoAtAll method and is non-configurable. Only a
small part of the policy was in defaultBuildsRepoPolicy.

For golang/go#39156.

Change-Id: Ie7c6a68bd624056362dc7d964bd8d640f665b35a
Reviewed-on: https://go-review.googlesource.com/c/build/+/240687
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Alexander Rakoczy <alex@golang.org>
@golang golang locked and limited conversation to collaborators Jul 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants