Repository navigation
testing: rename t.TempDir to t.Mkdir #39169
Description
Activity
I was initially against this name, because I thought
testing.T.Mkdircould be confused foros.Mkdir. But Roger correctly pointed out that's very unlikely, sincetesting.T.Mkdirdoes not take any arguments.Change https://golang.org/cl/234558 mentions this issue:
testing: rename TempDir to MkdirMkdir does not convey "this is temporary". (It's not ioutil.Mkdir.) Let's leave it as TempDir. I understand the conflict with os.TempDir, but more people know about ioutil.TempDir anyway. Thanks.
Fair enough. Will close.
- locked and limited conversation to collaborators
on May 20, 2021
The originally proposed name for
testing.T.TempDirwasMkdir. The name was changed during the proposal process. There has been some confusion about the intended semantics: is it more likeioutil.TempDiroros.TempDir?To avoid the confusion, I suggest that we use the originally proposed name,
Mkdir. It's then very clear that the method is creating a new directory. The fact that the method has no arguments is a clear indication that the directory name is chosen by the method itself rather than by the caller.