Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/exp/cmd/gorelease: set allowed changes with -compatibility flag #39191

Open
jayconrod opened this issue May 21, 2020 · 0 comments
Open

x/exp/cmd/gorelease: set allowed changes with -compatibility flag #39191

jayconrod opened this issue May 21, 2020 · 0 comments

Comments

@jayconrod
Copy link
Contributor

@jayconrod jayconrod commented May 21, 2020

Currently, gorelease determines whether compatible and incompatible API changes are allowed based on the module base version and release version. It follows semver guidelines, for example, allowing incompatible changes at base major version v0.

Users may want to apply different (usually stricter) compatibility guidelines. For example, a module may want to forbid incompatible API changes between minor versions at v0, even though semver allows them.

gorelease should accept a -compatibility flag that allows users to set the compatibility level explicitly. For example:

gorelease -base=v0.10.0 -release=v0.10.1 -compatibility=patch
gorelease -base=v0.10.0 -release=v0.11.0 -compatibility=minor
gorelease -base=v0.10.0 -release=v0.15.0 -compatibility=major

cc @liggitt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant