Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build: support an x/tools SlowBot for platforms other than linux-amd64 #39201

Open
bcmills opened this issue May 21, 2020 · 1 comment
Open

x/build: support an x/tools SlowBot for platforms other than linux-amd64 #39201

bcmills opened this issue May 21, 2020 · 1 comment

Comments

@bcmills
Copy link
Member

@bcmills bcmills commented May 21, 2020

I suspect that pending CL 234879 may break some x/tools tests on Windows specifically, but it's a huge pain to set up a gomote instance capable of testing x/tools in a realistic configuration (see #32430), and I don't keep a Windows development workstation running otherwise.

The current SlowBot support allows me to add an x/tools run for linux-amd64 by adding a comment with:

TRY=x/tools

And it currently allows me to add a Windows long-test run by adding a comment with:

TRY=windows-amd64-longtest

Unfortunately, it does not seem to support the combination of the two: a run for x/tools in the windows-amd64-longtest configuration. It would be very convenient for me if it did.

CC @golang/osp-team @stamblerre @ianthehat

@dmitshur
Copy link
Member

@dmitshur dmitshur commented May 21, 2020

SlowBots are intended to allow custom and slow testing, so I believe this is in scope. It's a matter of figuring out a syntax for it and implementing the feature.

As a starting point, I'll suggest the following syntax:

# picks default linux-amd64 builder to test x/tools
TRY=x/tools
# tests x/tools with windows-amd64-longtest builder
TRY=x/tools@windows-amd64-longtest
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.