Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls: invalid completions on RHS of ":=" #39203

Open
muirdm opened this issue May 21, 2020 · 1 comment
Open

x/tools/gopls: invalid completions on RHS of ":=" #39203

muirdm opened this issue May 21, 2020 · 1 comment
Labels
Milestone

Comments

@muirdm
Copy link

@muirdm muirdm commented May 21, 2020

On gopls master (91d71f6c2f04d59719a95392fef75b3c4c00d375):

fooBar := fo<> 

You get a completion for "fooBar" which doesn't make sense since "fooBar" isn't declared yet. We have a similar special case check for "var" declarations, so we probably just need to apply it to ":=" as well. ":=" is a bit trickier since some of the LHS values might already be declared.

@gopherbot gopherbot added the Tools label May 21, 2020
@gopherbot
Copy link

@gopherbot gopherbot commented May 21, 2020

Thank you for filing a gopls issue! Please take a look at the Troubleshooting guide, and make sure that you have provided all of the relevant information here.

@gopherbot gopherbot added the gopls label May 21, 2020
@gopherbot gopherbot added this to the Unreleased milestone May 21, 2020
@stamblerre stamblerre modified the milestones: Unreleased, gopls/v0.5.0 May 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.