Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
x/build/cmd/gopherbot: released things get marked Unreleased #39213
Any issue in an x/ package that is vendored into the release should not be milestoned Unreleased by Gopherbot.
Issue #32441 was left alone for a long time in part because it was in the Unreleased milestone.
In addition to fixing Gopherbot, we may want to investigate potentially mis-milestoned issues.
#38064 x/net/http2/h2c: POST from Java 11 client code causing error in h2cUpgrade
#9055 x/text/unicode/norm: LastBoundary is inconsistent
Yep. The logic for this is https://github.com/golang/build/blob/master/cmd/gopherbot/gopherbot.go#L835
Edit: we explicitly leave out vendored subrepos: https://github.com/golang/build/blob/master/cmd/gopherbot/gopherbot.go#L851 but the above issues don’t meet the initial requirements to be excluded, so they can bucketed in “Unreleased” then never moved out.
Issue #32441 was unfortunate in that it both had a "x/" prefix, yet it didn't match a real package "x/net/http2" that exists and is vendored.
One way to make that task of adding "Unreleased" milestone less likely to be applied on the wrong issues, without also causing more work for humans doing the issue triage, is if we start (automatically) tracking directories that exist in golang.org/x repos and packages that are vendored in the past 2 releases. (For an example of this being done, see the source code behind the https://goissues.org/-/packages page.)
Then it becomes possible to make it only add the "Unreleased" milestone if a the issue prefix matches a real package that exists, and that package isn't vendored.
This would prevent the milestone from being incorrectly added when an issue mistitled like "x/net/http" (instead of "net/http"). But it wouldn't help if it's mistitled like "x/image/draw" (instead of "image/draw") because