Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls: repeats completion prefix for identifiers in comments #39262

Closed
heschik opened this issue May 26, 2020 · 4 comments
Closed

x/tools/gopls: repeats completion prefix for identifiers in comments #39262

heschik opened this issue May 26, 2020 · 4 comments
Assignees
Milestone

Comments

@heschik
Copy link
Contributor

@heschik heschik commented May 26, 2020

With gopls at tip, completing in comments doesn't overwrite the completion prefix. For example, in:

package main

// Foo<>
func FooDoesAThing() {}

you get a completion that yields

package main

// FooFooDoesAThing
func FooDoesAThing() {}

cc @clintjedwards

@gopherbot gopherbot added this to the Unreleased milestone May 26, 2020
@stamblerre stamblerre modified the milestones: Unreleased, gopls/v0.5.0 May 26, 2020
@clintjedwards
Copy link

@clintjedwards clintjedwards commented May 27, 2020

@heschik looking at it

@clintjedwards
Copy link

@clintjedwards clintjedwards commented Jul 7, 2020

Apologies, I've been super busy with other projects. Taking a look at this, this week.

@stamblerre stamblerre added the NeedsFix label Jul 23, 2020
@stamblerre stamblerre added this to the gopls/v1.0.0 milestone Jul 23, 2020
@clintjedwards
Copy link

@clintjedwards clintjedwards commented Jul 26, 2020

I've poked and prodded at this over the last week and I've mostly been stuck trying to parse the logic around how the prefixes are handled for other instances of this issue. Unfortunately, I'm no closer to solving it and I'm going through a move and job switch at the moment so I can't dedicate any time in the near term.

Throwing back to the pool for someone else to hopefully pick up. Apologies!

@dandua98 dandua98 self-assigned this Jul 29, 2020
@gopherbot
Copy link

@gopherbot gopherbot commented Jul 31, 2020

Change https://golang.org/cl/246237 mentions this issue: internal/lsp/source: Fix completion in comments not overwriting completion prefix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants