net/http: Re-connect with upgraded HTTP2 connection fails to send Request.body [1.14 backport] #39279
Comments
|
Approved as this is a serious enough regression with no suitable workaround. |
|
Change https://golang.org/cl/242117 mentions this issue: |
|
This change caused a number of issues when tested internally, and it seems that the fix to #39533 must also be backported if we want to avoid the same fate externally. This backport cannot be landed until the follow-up fix is cherry-picked. As we are aiming to release the next point release today, I’m pushing this off for now. Apologies for the inconvenience. |
Opened #40973 as a backport issue for that fix, and made the cherry-pick CL 249880. |
|
Closed by merging 0d8ee35 to release-branch.go1.14. |
…tion loss better In certain cases the HTTP/2 stack needs to resend a request. It obtains a fresh body to send by calling req.GetBody. This call was missing from the path where the HTTP/2 round tripper returns ErrSkipAltProtocol, meaning fall back to HTTP/1.1. The result was that the HTTP/1.1 fallback request was sent with no body at all. This CL changes that code path to rewind the body before falling back to HTTP/1.1. But rewinding the body is easier said than done. Some requests have no GetBody function, meaning the body can't be rewound. If we need to rewind and can't, that's an error. But if we didn't read anything, we don't need to rewind. So we have to track whether we read anything, with a new ReadCloser wrapper. That in turn requires adding to the couple places that unwrap Body values to look at the underlying implementation. This CL adds the new rewinding code in the main retry loop as well. The new rewindBody function also takes care of closing the old body before abandoning it. That was missing in the old rewind code. Thanks to Aleksandr Razumov for CL 210123 and to Jun Chen for CL 234358, both of which informed this CL. Updates #32441. Fixes #39279. Change-Id: Id183758526c087c6b179ab73cf3b61ed23a2a46a Reviewed-on: https://go-review.googlesource.com/c/go/+/234894 Run-TryBot: Russ Cox <rsc@golang.org> Reviewed-by: Damien Neil <dneil@google.com> Reviewed-by: Bryan C. Mills <bcmills@google.com> (cherry picked from commit e3491c4) Reviewed-on: https://go-review.googlesource.com/c/go/+/242117 Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Emmanuel Odeke <emm.odeke@gmail.com>
@networkimprov requested issue #32441 to be considered for backport to the next 1.14 minor release.
The text was updated successfully, but these errors were encountered: