Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
GitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
proposal: standard library optimizations #39314
I am going around the standard library and trying to find things to improve.
These benchmarks are on random data.
BenchmarkEqualIgnoreCase-8 12356467 93.7 ns/op
Even while this is closed. A suggestion. Please use https://pkg.go.dev/golang.org/x/perf/cmd/benchstat?tab=doc and run multiple rounds (10 or 20) on a quiet machine to get output that looks like:
Its easier to judge the relative and consistency of the speedup that way.
@martisch so you don't want these types of contributions?
Contributions that improve the speed of the standard library are welcome.
There really isn't a need for a meta-issue like this, so it doesn't need to be open. Go ahead and submit specific optimization CLs when you have them. The contribution guide explains how to do it, if you haven't seen that already.
The optimization you propose for
Thats neither what I wrote nor my intention. I had assumed since you earlier closed the issue that this should have been stayed close as it was reopened without comment.
For discussions and questions about contributions its better to use https://groups.google.com/g/golang-dev.
Generally feel free to send performance improving CLs that show concretely where and how the code will be changed and the benchmark data.
No need to make it a proposal which is a more involved process of e.g. proposing a public API change for go. https://github.com/golang/proposal#readme