Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build/cmd/releasebot: a possibility of an unexpected backport CL being merged to release branch between -mode=prepare and -mode=release #39317

Open
dmitshur opened this issue May 30, 2020 · 0 comments

Comments

@dmitshur
Copy link
Member

@dmitshur dmitshur commented May 30, 2020

Currently, the release process involves running releasebot first in prepare mode, then again in release mode.

For release types other than beta, a CL that updates the VERSION file is created in prepare mode. It is also tested (soon, including longtest builders, see #29252). After that CL is submitted to the release branch, the release mode takes the latest commit on the release branch and produces a release, skipping all testing (because thorough testing was done in prepare mode).

There is a possibility of a change being submitted to the release branch between the time the CL updating the VERSION file is created and tested in prepare mode, and the release mode picking it up. That would mean the CL that landed would bypass all testing done in prepare mode.

This issue is low priority for two reasons:

  1. The chance of this happening is low because only a small set of release managers have access to submit changes to release branches, and we are generally aware when a release is happening and manually avoid touching the release branch.

  2. Additionally, changes to release branches undergo testing (soon, including longtest builders, see #37827), so there isn't a risk of introducing a problem that would be caught by testing.

However, it would still be unintentional if it happened, and it might require release notes to be updated. This is the tracking issue to investigate and implement a way to remove this small possibility of a human mistake. It was split off from #36182.

/cc @toothrot @cagedmantis @andybons

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.