Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls: support post-fix completion snippets #39354

Closed
liuwangchen opened this issue Jun 1, 2020 · 8 comments
Closed

x/tools/gopls: support post-fix completion snippets #39354

liuwangchen opened this issue Jun 1, 2020 · 8 comments

Comments

@liuwangchen
Copy link

@liuwangchen liuwangchen commented Jun 1, 2020

hope
image

image

@hyangah
Copy link
Contributor

@hyangah hyangah commented Jun 2, 2020

@liuwangchen Do you mean that you want a certain word at the end of a function call triggers autocompletion of LHS? In your example, .var is the certain word. Did I guess correctly?

@liuwangchen
Copy link
Author

@liuwangchen liuwangchen commented Jun 2, 2020

@hyangah Yes, I used goland to find this nice feature, and I hope this plugin will support it

@stamblerre stamblerre changed the title hope support postfix support post-fix completion snippets Jun 2, 2020
@stamblerre
Copy link
Contributor

@stamblerre stamblerre commented Jun 2, 2020

Thanks for the feature request! We likely will not be making improvements to the completions provided by this extension directly - rather, we will make changes in gopls. I will transfer this issue to https://github.com/golang/go as a gopls feature request.

@stamblerre stamblerre transferred this issue from golang/vscode-go Jun 2, 2020
@stamblerre stamblerre changed the title support post-fix completion snippets x/tools/gopls: support post-fix completion snippets Jun 2, 2020
@gopherbot
Copy link

@gopherbot gopherbot commented Jun 2, 2020

Thank you for filing a gopls issue! Please take a look at the Troubleshooting guide, and make sure that you have provided all of the relevant information here.

@gopherbot gopherbot added this to the Unreleased milestone Jun 2, 2020
@stamblerre stamblerre added FeatureRequest and removed Tools gopls labels Jun 2, 2020
@liuwangchen
Copy link
Author

@liuwangchen liuwangchen commented Jun 3, 2020

very nice~

@liuwangchen
Copy link
Author

@liuwangchen liuwangchen commented Jun 29, 2020

image

image

image

hope support bracket post-fix snippet

@stamblerre stamblerre removed this from the Unreleased milestone Jul 23, 2020
@stamblerre stamblerre added this to the gopls/unplanned milestone Oct 21, 2020
@muirdm
Copy link

@muirdm muirdm commented Nov 23, 2020

See #39507 (comment).

@stamblerre should we close this issue in favor of #39507? Or should we use this issue to track the postfix stuff?

@stamblerre
Copy link
Contributor

@stamblerre stamblerre commented Nov 24, 2020

We can close it in favor of #39507 -- didn't realize we had both open. Thanks! Looking forward to playing with the postfix suggestions!

@stamblerre stamblerre closed this Nov 24, 2020
@stamblerre stamblerre removed this from the gopls/unplanned milestone Nov 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants