Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime: runtime-gdb.py does not work on RHEL #39387

Closed
laboger opened this issue Jun 3, 2020 · 3 comments
Closed

runtime: runtime-gdb.py does not work on RHEL #39387

laboger opened this issue Jun 3, 2020 · 3 comments

Comments

@laboger
Copy link
Contributor

@laboger laboger commented Jun 3, 2020

What version of Go are you using (go version)?

$ go version
go version devel +9984ef8 Wed Jun 3 19:07:55 2020 +0000 linux/ppc64le

Does this issue reproduce with the latest release?

Yes

What operating system and processor architecture are you using (go env)?

@dr2chase
I just tried to do a build on a ppc64le RHEL8 system and this test fails in the same way as on the dashboard for s390x. The bad output is:

Loading Go Runtime support.
        Traceback (most recent call last):
          File "/data/golang/workdir/go/src/runtime/runtime-gdb.py", line 33, in <module>
            majorgdbversion = int(splitgdbversion[0])
        ValueError: invalid literal for int() with base 10: 'Red Hat Enterprise Linux 8'

Looks like the recent update to parse the gdb version is not handling Red Hat output correctly?
The ppc64le builders are not Red Hat so they aren't failing on the dashboard.

@dr2chase
Copy link
Contributor

@dr2chase dr2chase commented Jun 3, 2020

Fixed as of a few minutes ago, latest change uses regexps for all possible inputs instead of parsing version "numbers". See https://go-review.googlesource.com/c/go/+/236280

@laboger
Copy link
Contributor Author

@laboger laboger commented Jun 3, 2020

Thanks! I noticed you had started a CL for this after I opened the issue. Just tried it out and works fine.

@laboger laboger closed this Jun 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.