Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls: rename in GOPATH mode does not rename test variant #39394

Open
stamblerre opened this issue Jun 4, 2020 · 1 comment
Open

x/tools/gopls: rename in GOPATH mode does not rename test variant #39394

stamblerre opened this issue Jun 4, 2020 · 1 comment
Labels

Comments

@stamblerre
Copy link
Contributor

@stamblerre stamblerre commented Jun 4, 2020

I was running through the steps in https://github.com/golang/vscode-go/blob/master/docs/Smoke-Test.md, with the example repository in GOPATH mode. Renaming stringutil.Reverse resulted in an error in the reverse_test.go file, as the version in the test variant was not renamed.

@stamblerre stamblerre added this to the gopls/v0.5.0 milestone Jun 4, 2020
@stamblerre stamblerre modified the milestones: gopls/v0.5.0, gopls/v1.0.0 Jul 22, 2020
@stamblerre
Copy link
Contributor Author

@stamblerre stamblerre commented Sep 9, 2020

Removing from the 1.0 milestone, as GOPATH bugs are not critical.

Edit: Confirmed that I cannot reproduce this in module mode.

@stamblerre stamblerre removed this from the gopls/v1.0.0 milestone Sep 9, 2020
@stamblerre stamblerre added this to the gopls/unplanned milestone Oct 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants