Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crypto/x509: SKID generation is over full spki, rather than just the subjectPublicKey #39429

Closed
rolandshoemaker opened this issue Jun 5, 2020 · 3 comments
Assignees
Labels
Milestone

Comments

@rolandshoemaker
Copy link
Member

@rolandshoemaker rolandshoemaker commented Jun 5, 2020

https://go-review.googlesource.com/c/go/+/227098 introduced automatic SKID generation when one isn't provided using method (1) from RFC 5280 Section 4.2.1.2. The hash provided is over the full SPKI structure, rather than just the subjectPublicKey BIT STRING as defined, which makes it out of line with certain other implementations that assume this is how the SKID is generated.

This is unlikely to break anything major, but if the goal is to use the RFC 5280 method as defined it would make sense to stick to that construction.

@dmitshur dmitshur added this to the Go1.15 milestone Jun 5, 2020
@dmitshur
Copy link
Member

@dmitshur dmitshur commented Jun 5, 2020

Thanks for reporting this @rolandshoemaker.

That CL was for to fix issue #26676.

/cc @katiehockman @FiloSottile

@FiloSottile
Copy link
Member

@FiloSottile FiloSottile commented Jun 6, 2020

Ah, good catch, looks like I got this wrong in the review even if Katie had suggested using the correct value. Better fix this for Go 1.15.

@gopherbot
Copy link

@gopherbot gopherbot commented Jun 7, 2020

Change https://golang.org/cl/236878 mentions this issue: crypto/x509: match RFC suggested SKID generation method

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants
You can’t perform that action at this time.