-
Notifications
You must be signed in to change notification settings - Fork 17.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/build/env/android-*-emu: adb does not propagate GO_BUILDER_NAME to tests #39460
Comments
From the linked CL:
The printed
That is interesting. |
I just got bitten by this while working on #43554. I thought that I'd disabled regtests on android, similar to other builders, and my guard wasn't working. Before I found this issue, I looked into it a bit. I think the problem is that only certain environment variables are sent via adb: |
Updated the title as this affects 386 as well. |
This should be fixed, but OTOH varying a test's behavior based on If a test is failing when our builders run it, it's probably failing when our users run it too, and they shouldn't need to set |
@bcmills I don't want to stray too far off-topic here, but I do think that skipping tests based on |
@bcmills it occurred to me that perhaps you meant simply that if the test fails on Android, it should be guarded with |
Change https://golang.org/cl/284935 mentions this issue: |
Remove the exception for the Android amd64 builder, now that flakes are fixed (though the exception didn't actually work anyway due to golang/go#39460). Also, accept the import reorganization applied by gopls. Fixes golang/go#43554 Change-Id: I9a7cce35998cfa673699d74a487111e4daecf7ec Reviewed-on: https://go-review.googlesource.com/c/tools/+/284935 Trust: Robert Findley <rfindley@google.com> Run-TryBot: Robert Findley <rfindley@google.com> gopls-CI: kokoro <noreply+kokoro@google.com> TryBot-Result: Go Bot <gobot@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org>
The GO_BUILDER_NAME environment variable doesn't seem to be set on tests running on the android-amd64-emu builders.
How to reproduce:
I created CL 236960 with the following test in it:
on the android-amd64-emu builder, the test fails with the following error:
The text was updated successfully, but these errors were encountered: