Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls: implement callHierarchy #39461

Open
josh-tepper-clarifai opened this issue Jun 8, 2020 · 3 comments
Open

x/tools/gopls: implement callHierarchy #39461

josh-tepper-clarifai opened this issue Jun 8, 2020 · 3 comments

Comments

@josh-tepper-clarifai
Copy link

@josh-tepper-clarifai josh-tepper-clarifai commented Jun 8, 2020

I'd love to see gopls implement the new LSP Call Hierarchy feature. I'd look forward to using it in VSCode which already supports it.

This was discussed as a "Preview Feature" in the VSCode release notes from March:
https://code.visualstudio.com/updates/v1_33#_preview-features

At the time, this LSP API was still in preview, but with the upcoming 3.16 LSP specification, I believe that this is no longer the case:
https://microsoft.github.io/language-server-protocol/specifications/specification-3-16/

As you can see from the screenshot included in the VSCode release notes, VSCode provides a nice ui when the language server implements this:
call-hierarchy

I see that others have requested this feature on the vscode-go repo, but I don't see a ticket here:
microsoft/vscode-go#2682

I share the sentiment of the other user: this would be a great addition and would be very useful for me in my day to day work.

@gopherbot gopherbot added this to the Unreleased milestone Jun 8, 2020
@stamblerre stamblerre changed the title x/tools/cmd/gopls: Implement LSP call Hierarchy x/tools/cmd/gopls: implement LSP call Hierarchy Jul 1, 2020
@josh-tepper-clarifai
Copy link
Author

@josh-tepper-clarifai josh-tepper-clarifai commented Jul 7, 2020

I wanted to follow up on this ticket. I think that this type of interface would be a big asset when trying to quickly understand a piece of code

@stamblerre stamblerre changed the title x/tools/cmd/gopls: implement LSP call Hierarchy x/tools/gopls: implement LSP call Hierarchy Jul 7, 2020
@golang golang deleted a comment from gopherbot Jul 7, 2020
@stamblerre
Copy link
Contributor

@stamblerre stamblerre commented Jul 7, 2020

Agreed! We intend to support all LSP features in the future, but this isn't as high priority as some other bug fixes / features that we're currently working on.

@josh-tepper-clarifai
Copy link
Author

@josh-tepper-clarifai josh-tepper-clarifai commented Jul 7, 2020

Got it. Sounds good

@stamblerre stamblerre changed the title x/tools/gopls: implement LSP call Hierarchy x/tools/gopls: implement callHierarchy Jul 23, 2020
@stamblerre stamblerre removed this from the Unreleased milestone Jul 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.