Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

contribution best practice #39469

Closed
mostafasolati opened this issue Jun 9, 2020 · 1 comment
Closed

contribution best practice #39469

mostafasolati opened this issue Jun 9, 2020 · 1 comment

Comments

@mostafasolati
Copy link

@mostafasolati mostafasolati commented Jun 9, 2020

Hi everyone.
I have a question, I don't know if it's a good place to ask or not.
I apologize in advance if it's not the proper place.

I want to add examples for some methods of a package. What is best practice for doing that?
An example in each CL or multiple examples in one CL?

@martisch
Copy link
Contributor

@martisch martisch commented Jun 9, 2020

Hi,

It is better to ask these kind of questions on the golang-dev mailing list or #contributing in Gophers Slack. See https://github.com/golang/go/wiki/Questions.

My personal opinion is that it matters how many lines there are in the CL, how complex the examples are and how closely related they are. For examples in different pakages I would start with separate CLs.

@martisch martisch closed this Jun 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.