Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build/cmd/release: leave oldlink binary out of RC1 (if the beta doesn't uncover serious linker issues) #39509

Open
toothrot opened this issue Jun 10, 2020 · 4 comments
Assignees
Milestone

Comments

@toothrot
Copy link
Contributor

@toothrot toothrot commented Jun 10, 2020

As part of https://golang.org/s/better-linker, we now build a binary called oldlinker in our release of Go. While it may be useful to include in the beta, we should make a decision on whether this is included in the RC or final releases of Go 1.15, vs asking people to rebuild it on their own if necessary.

/cc @cherrymui @aclements @golang/osp-team

@aclements
Copy link
Member

@aclements aclements commented Jun 10, 2020

/cc @jeremyfaller @thanm

I think it's a good idea to include this in the beta. While our internal testing gets good coverage of certain configurations, it doesn't get very good coverage of others, and shipping this in the beta will help with any problems uncovered there.

However, the new linker roll out has been going really smoothly so far. Assuming the beta doesn't uncover any serious linker issues, I'd be inclined to leave oldlink out of the RC.

@toothrot toothrot self-assigned this Jun 10, 2020
@cherrymui
Copy link
Contributor

@cherrymui cherrymui commented Jun 10, 2020

@aclements 's suggestion SGTM.

A test may fail if the old linker is not present. We could change the test to skip if the binary does not exist.

@thanm
Copy link
Member

@thanm thanm commented Jun 10, 2020

I'm happy with @aclements 's suggestion too.

@aclements
Copy link
Member

@aclements aclements commented Jun 11, 2020

It was really @toothrot 's suggestion, so I think we're all in agreement. :)

@dmitshur dmitshur changed the title x/build/cmd/release: decide whether to include oldlink binary in release x/build/cmd/release: leave oldlink binary out of RC1 (if the beta doesn't uncover serious linker issues) Jun 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
6 participants
You can’t perform that action at this time.