cmd/compile: can not decrement atomic uint64(0)

[Sasasu]

What version of Go are you using (go version)?

$ go version
go version go1.14.4 linux/amd64

Does this issue reproduce with the latest release?

https://play.golang.org/p/Qf-Pfg1vzeZ

package main

import "sync/atomic"

func main() {
	var foo uint64 = 1
	atomic.AddUint64(&foo, ^(0))
}

What operating system and processor architecture are you using (go env)?

go env Output

$ go env
> on goplayground

What did you do?

atomic.AddUint64(&foo, ^(0))

according to this

go/src/sync/atomic/doc.go

Lines 103 to 106 in 509ee70

	// AddUint64 atomically adds delta to *addr and returns the new value.
	// To subtract a signed positive constant value c from x, do AddUint64(&x, ^uint64(c-1)).
	// In particular, to decrement x, do AddUint64(&x, ^uint64(0)).
	func AddUint64(addr *uint64, delta uint64) (new uint64)

What did you expect to see?

compile success, decrement uint64(0) got undefined behavior.

What did you see instead?

constant -1 overflows uint64

[DisposaBoy]

I see you fixed the original issue by switching to atomic.AddUint64.
I think the new error is guarding against what's usually a bug since you can't store a negative number in an unsigned integer.

[davecheney]

As the comment says ^uint64(0) is what you need to use.

https://play.golang.org/p/Ru41D6UTSUb