Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
x/tools/gopls: diagnostics are produced for packages beginning with underscore #39563
Please answer these questions before submitting your issue. Thanks!
What did you do?
What did you expect to see?
What did you see instead?
Too many diagnostics for a package I don't care to see diagnostics on. The only way to remove the diagnostics seems to be to restart vscode.
While unwanted diagnostics might not seem like a big issue on vscode, where the user usually don't look at the Problems window, it's a larger issue for editors that don't support highlighting problems within the file buffer (e.g. acme-lsp). In those editors, the Problems window is the only way to see the diagnostics.
That CL is unrelated, since it was ignoring individual files that start with _, not whole directories. I reproduced and gopls is doing a many-file packages.Load, which is presumably the orphaned file handling kicking in because the workspace load correctly ignored _test.
Guess we need to duplicate