Skip to content

/ go

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/pkgsite: data race when handling errors rendering the status page #39611

Closed
uhthomas opened this issue Jun 16, 2020 · 5 comments
Closed

x/pkgsite: data race when handling errors rendering the status page #39611

uhthomas opened this issue Jun 16, 2020 · 5 comments
Labels
NeedsFix help wanted pkgsite
Milestone
Unreleased

Comments

@uhthomas
Copy link

@uhthomas uhthomas commented Jun 16, 2020 •
edited

What is the URL of the page with the issue?

N/A

What is your user agent?

N/A

Screenshot

N/A

What did you do?

N/A

What did you expect to see?

Out of curiosity, I was reading the source for pkgsite, and came across this func which has a racy assignment to errString.

What did you see instead?

A non-racy assignment to errString.

Is this tracked elsewhere? If not, I don't mind picking it up 😄
@gopherbot gopherbot added the pkgsite label Jun 16, 2020
@gopherbot gopherbot added this to the Unreleased milestone Jun 16, 2020
@julieqiu
Copy link
Contributor

@julieqiu julieqiu commented Jun 16, 2020

It's not - feel free to send a fix!

/cc @jba
@julieqiu julieqiu added help wanted NeedsFix labels Jun 16, 2020
@julieqiu julieqiu changed the title go.dev: Data race when handling errors rendering the status page go.dev: data race when handling errors rendering the status page Jun 16, 2020
@julieqiu julieqiu changed the title go.dev: data race when handling errors rendering the status page x/pkgsite: data race when handling errors rendering the status page Jun 16, 2020
@uhthomas
Copy link
Author

@uhthomas uhthomas commented Jun 16, 2020

Will get on it 😄
@jba
Copy link
Contributor

@jba jba commented Jun 16, 2020

Good catch!
@uhthomas
Copy link
Author

@uhthomas uhthomas commented Jun 16, 2020

Not sure why the GopherBot didn't pick it up, but the changes can be found here.
@julieqiu
Copy link
Contributor

@julieqiu julieqiu commented Jun 19, 2020

Fixed by https://go-review.googlesource.com/c/pkgsite/+/238041.
@julieqiu julieqiu closed this Jun 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
NeedsFix help wanted pkgsite
Projects
None yet
Milestone
Unreleased
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
@julieqiu @gopherbot @uhthomas @jba