Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/pkgsite: replace all internal Googler links #39621

Open
mvdan opened this issue Jun 16, 2020 · 6 comments
Open

x/pkgsite: replace all internal Googler links #39621

mvdan opened this issue Jun 16, 2020 · 6 comments
Labels
Milestone

Comments

@mvdan
Copy link
Member

@mvdan mvdan commented Jun 16, 2020

I see links like TODO(b/139530312), which I assume is an issue link I can't access or at least some text that doesn't make any sense to me.

If we're going to use this issue tracker alone in the future, like other x repos, we should replace all of those with links to issues here. Some TODOs are this way already, such as TODO(golang/go#38513).

Current counts:

$ git log -1 --oneline
7f80893 (HEAD -> master, origin/master, origin/HEAD) internal/database: fix bug with error handling in transact
$ git grep 'TODO(b/' | wc -l
26
$ git grep 'TODO(.*#' | wc -l
8

/cc @julieqiu @jba

@gopherbot gopherbot added this to the Unreleased milestone Jun 16, 2020
@julieqiu
Copy link
Contributor

@julieqiu julieqiu commented Jun 16, 2020

Thanks for catching! We'll work on fixing these.

@gopherbot
Copy link

@gopherbot gopherbot commented Jun 17, 2020

Change https://golang.org/cl/238319 mentions this issue: internal: clean up issue links

gopherbot pushed a commit to golang/pkgsite that referenced this issue Jun 17, 2020
This is the first CL to clean up various TODOs that are outdated, and
replace internal issue links with GitHub issue links.

Updates golang/go#39621

Change-Id: If270e8b2e8198c007cb4aa71ad8486182f4f3380
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/238319
Reviewed-by: Jonathan Amsterdam <jba@google.com>
@gopherbot
Copy link

@gopherbot gopherbot commented Jun 17, 2020

Change https://golang.org/cl/238577 mentions this issue: all: clean up issue links

@dmitshur
Copy link
Member

@dmitshur dmitshur commented Jun 27, 2020

There are a few more instances that can be found without the "TODO" prefix:

$ git log -1 --oneline --no-decorate
08e8e66 internal/worker: add /poll and /enqueue endpoints.
$ git grep -E 'b/[0-9]{4}' | wc -l
      12
@dmitshur dmitshur reopened this Jun 27, 2020
@gopherbot
Copy link

@gopherbot gopherbot commented Jun 27, 2020

Change https://golang.org/cl/240187 mentions this issue: internal/fetch/dochtml: update package documentation and issue numbers

@dmitshur
Copy link
Member

@dmitshur dmitshur commented Jun 27, 2020

Only 7 more to go after CL 240187.

gopherbot pushed a commit to golang/pkgsite that referenced this issue Jun 30, 2020
There has been progress made since the package comments
were written. Update them to reflect the current state.

For golang/go#39621.

Change-Id: I3f950428a96bc0561b45b0d49117d2eda58d3cf7
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/240187
Reviewed-by: Julie Qiu <julie@golang.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.