Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/pkgsite: add second module to testdata for frontend.testServer #39631

Closed
julieqiu opened this issue Jun 17, 2020 · 5 comments
Closed

x/pkgsite: add second module to testdata for frontend.testServer #39631

julieqiu opened this issue Jun 17, 2020 · 5 comments

Comments

@julieqiu
Copy link
Contributor

@julieqiu julieqiu commented Jun 17, 2020

Add a second module to testdata for frontend.testServer, so that we can verify that we are getting the latest version:

https://github.com/golang/pkgsite/blob/a2ecf39/internal/frontend/server_test.go#L570

Related: #39621

@AndersonQ
Copy link
Contributor

@AndersonQ AndersonQ commented Jul 7, 2020

I can take it :)

@julieqiu
Copy link
Contributor Author

@julieqiu julieqiu commented Jul 7, 2020

Thank you!

@gopherbot
Copy link

@gopherbot gopherbot commented Jul 7, 2020

Change https://golang.org/cl/241297 mentions this issue: internal/frontend: add check to ensure latest module version is loaded

@AndersonQ
Copy link
Contributor

@AndersonQ AndersonQ commented Jul 7, 2020

The current "ordinary" module already has got multiple versions. Then I just added a check to ensure the latest version is the one loaded.
I believe it should cover the issue, right?

@julieqiu
Copy link
Contributor Author

@julieqiu julieqiu commented Jul 7, 2020

Yup, thanks for the fix! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants